[ClangImporter] Switch lookupGlobalsAsMembers to take a non-optional EffectiveClangContext
#74683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l EffectiveClangContext The only caller is `loadNamedMembers`, and that passes in a non-optional EffectiveClangContext, meaning that we'd miss the case when `getEffectiveClangContext` returns `nullptr`, crashing in `translateContext`. No test case unfortunately as I haven't been able to come up with a reproducer. rdar://129619711
hamishknight
requested review from
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
beccadax
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only caller is
loadNamedMembers, and that passes in a non-optional EffectiveClangContext, meaning that we'd miss the case whengetEffectiveClangContextreturnsnullptr, crashing intranslateContext. No test case unfortunately as I haven't been able to come up with a reproducer.rdar://129619711