Skip to content

Some assertion improvements #74685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

eeckstein
Copy link
Contributor

  • remove the obsolete require and replace its uses with the new ASSERT macro
  • forward assertion and precondition failures in SwiftCompilerSources to the assertion-handling in the C++ code base
  • display the assertion help hint only once and after the assertion message (It's more readable if the first thing which is printed is the actual assertion message)

…the assertion-handling in the C++ code base.
…ssertion message

It's more readable if the first thing which is printed is the actual assertion message
@eeckstein eeckstein requested a review from tbkka June 25, 2024 12:18
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein eeckstein merged commit b68c55c into swiftlang:main Jun 26, 2024
5 checks passed
@eeckstein eeckstein deleted the assertion-improvements branch June 26, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants