Sema: Suppress set accessor availability diagnostics in LoadExprs
#74690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the new FIXMEs demonstrate the regression reported in rdar://129679658.
This fixes a regression from swiftlang#72369. The compiler now incorrectly diagnoses use of an unavailable setter in this example: ``` func increaseBrightness(in window: UIWindow) { // warning: setter for 'screen' was deprecated in iOS 13.0 window.screen.brightness = 1.0 } ``` While the setter is deprecated, it would not be called in the generated code since `screen` is a reference type and there is no writeback through the setter for `screen` after setting `brightness`. Resolves rdar://129679658
tshortli
force-pushed
the
accessor-availability-reference-types
branch
from
93ec588 to
95cf7cf
Compare
Fixes missing setter availability diagnostics in some edge cases.
tshortli
force-pushed
the
accessor-availability-reference-types
branch
from
95cf7cf to
31df22f
Compare
|
@swift-ci please smoke test |
beccadax
approved these changes
Jun 25, 2024
xedin
approved these changes
Jun 25, 2024
|
I have some new reports with additional test cases that aren't fixed by this but I'm going to build on top of it with another PR to fix those. |
|
@tshortli Sounds good! |
|
Further iteration here: #74793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #72369. The compiler now incorrectly diagnoses use of an unavailable setter in this example:
While the setter is deprecated, it would not be called in the generated code since
screenis a reference type and there is no writeback through the setter forscreenafter settingbrightness.Resolves rdar://129679658