[Sema] Raise impact of DefineMemberBasedOnUse to match RemoveInvalidCall #74692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Jun 25, 2024
lib/Sema/CSSimplify.cpp
Outdated
| @@ -11115,7 +11115,7 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyMemberConstraint( | |||
|
|
|||
| auto instanceTy = baseObjTy->getMetatypeInstanceType(); | |||
|
|
|||
| auto impact = 2; | |||
| auto impact = 10; | |||
There was a problem hiding this comment.
How about we increase this to 4 and lower RemoveInvalidCall impact to 3, we already increase this by a lot if a the base doesn't have a member.
There was a problem hiding this comment.
Sure. Testing that.
|
Yep, just realized that and was adding the test... |
|
Impact scores of 4 and 3 works, and also improves a couple other places that now have better diagnostics. You may want to check the status of radar 86611718 - there's a comment in an improved test mentioning it. @swift-ci Please smoke test. |
|
Checks didn't run for whatever reason. @swift-ci Please smoke test. |
xedin
approved these changes
Jun 25, 2024
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test. |
auto-merge was automatically disabled
June 28, 2024 19:32
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveInvalidCall has a fix impact of 10, which means that in this issue, the typechecker would rather invent a conformance and then a brand new member rather than find the actual problem.
Raising the impact of DefineMemberBasedOnUse to be equivalent to RemoveInvalidCall seems reasonable, since it is better to diagnose a member that exists but has the wrong type rather than create a member that doesn't exist.
Resolves #74617