[6.0 🍒][Compile Time Constant Extraction] Ensure macro-expanded declarations are visited in WMO #74712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are visited in WMO Resolves rdar://130036855
|
@swift-ci test |
nkcsgexi
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #74708
Explanation: When support for macro-expanded declarations was added to ConstExtract, it only ever applied to single-file compilation on a per-primary basis. Which means that the same code, when compiled in WMO, did not handle macro-generated extension declarations. This change brings WMO code-path in line with the per-primary extraction code path.
Risk: Low. WMO compilation will now match what happens per-primary in single-file compiles.
Testing: Automated test added to the compiler test suite.
Resolves rdar://130036855