[6.0][region-isolation] Given a .none #isolation parameter, infer the isolation from the callee rather than the isolated parameter. #74727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation from the callee rather than the isolated parameter. Otherwise, we will have differing isolation from other parameters since the isolations will look different since one will have the .none value as an instance and the other will not have one and instead will rely on the AST isolation info. That is the correct behavior here since we do not actually have an actor here. I also removed some undefined behavior in the merging code. The way the code should work is that we should check if the merge fails and in such a case emit an unknown pattern error... instead of not checking appropriately on the next iteration and hitting undefined behavior. rdar://130396399 (cherry picked from commit f43911b)
|
@swift-ci smoke test |
|
@swift-ci test |
tbkka
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This PR fixes an issue that affects the usage of functions that use
#isolated. The specific problem is that when we call such a function without an actual actor (so we go to the main queue), we improperly infer the isolation of the enum.none to be slightly different from the isolation of other parameters.The result is that one can get an isolation mismerge that then results in a "unknown pattern" error.
Radars:
Original PRs:
Risk: Low.
Testing: Added tests to the compiler.
Reviewer: @ktoso