[Serialization] Wire up the generic parameter of a protocol early. #7473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we deserialize a protocol declaration, we had a bunch of intervening code before it would deserialize and wire up its generic parameter (Self), including configuring the generic environment. If any of that code referenced an AssociatedTypeDecl of that protocol, the deserialization of the AssociatedTypeDecl could end up computing an erroneous type. This might be the source of the nondeterministic deserialization failure that seems to afflict AssociatedTypeDecls in rdar://problem/30382791.
|
@swift-ci please smoke test and merge |
|
But why was it non-deterministic? |
|
... we still don't know the source of nondeterminism here. |
|
Looks like this didn't do it. :-( https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_long-test/1624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deserialize a protocol declaration, we had a bunch of
intervening code before it would deserialize and wire up its generic
parameter (
Self), including configuring the generic environment. Ifany of that code referenced an
AssociatedTypeDeclof that protocol,the deserialization of the AssociatedTypeDecl could end up computing
an erroneous type.
This might be the source of the nondeterministic deserialization
failure that seems to afflict
AssociatedTypeDeclsinrdar://problem/30382791.