[6.0 🍒][Dependency Scanning] Respect the Language Option for cross-import overlay enablement #74787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
nkcsgexi
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #74750
Explanation: Unlike implicitly-built modules, enabling explicitly-built modules (
-explicit-module-build) always resulted in the compiler attempting to detect and import cross-import overlays, regardless of the compiler default and enable/disable flags passed to the compiler. This change alters the dependency scanner to respect the compiler language option to disable or enable cross-import overlay modules (-enable-cross-import-overlays/-disable-cross-import-overlays)Risk: Low, this change disables existing dependency scanning logic when the cross-import overlay feature is disabled.
Reviewed By: @cachemeifyoucan @nkcsgexi
Testing: Automated test added to the compiler test suite