[AST] Rewrite collectExportedImports() to be non-recursive. #74812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with recursion here is that if there are enough modules involved, this function will blow the process stack, particularly in the case where the `FileUnit`s are not `SourceFile`s, since in that instance a `SmallVector` gets allocated on the stack for each level of the recursion. rdar://130527640
|
@swift-ci Please test |
slavapestov
reviewed
Jun 28, 2024
| @@ -1535,31 +1535,36 @@ void ModuleDecl::ImportCollector::collect( | |||
| } | |||
|
|
|||
| static void | |||
| collectExportedImports(const ModuleDecl *module, | |||
| collectExportedImports(const ModuleDecl *topLevelModule, | |||
There was a problem hiding this comment.
This entire function is also just duplicating existing code in lib/AST/ImportCache.cpp.
daniel-grumberg
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with recursion here is that if there are enough modules involved, this function will blow the process stack, particularly in the case where the
FileUnits are notSourceFiles, since in that instance aSmallVectorgets allocated on the stack for each level of the recursion.rdar://130527640