Skip to content

[MoveOnlyAddressChecker] Complete block args. #74835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Jun 28, 2024

Now that the underlying issue (PrunedLiveness' merging of summaries for branch instructions) has been fixed ( at #74815 ), reinstate lifetime completion and add a test to verify that it behaves correctly.

This reverts commit c552b90 ("Temporarily turn off completing lifetimes of block arguments").

rdar://130427564

Now that the underlying issue (PrunedLiveness' merging of summaries for
branch instructions) has been fixed, reinstate lifetime completion and
add a test to verify that it behaves correctly.

This reverts commit c552b90
("Temporarily turn off completing lifetimes of block arguments").

rdar://130427564
@nate-chandler nate-chandler requested a review from kavon as a code owner June 28, 2024 22:08
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nate-chandler nate-chandler enabled auto-merge June 28, 2024 22:53
@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@nate-chandler nate-chandler merged commit c5e81dd into swiftlang:main Jun 29, 2024
7 of 8 checks passed
@nate-chandler nate-chandler deleted the rdar130427564_2 branch June 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants