Fix isTriviallyDuplicatable to handle open_pack_element #74842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
addopenpackedgecase
branch
from
f217fc9 to
559c61c
Compare
|
@swift-ci test |
SILInstruction::clone doesn't know how to clone instructions that produce the archetype uuid. SILCloner is equipped to handle such instructions. Optimizations like LoopRotate use SILInstruction::clone and will be incorrect for such instructions. rdar://130047619
meg-gupta
force-pushed
the
addopenpackedgecase
branch
from
559c61c to
5282194
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like other instructions that produce archetype uuid:
open_existential_addrandopen_existential_metatype,open_pack_elementis not trivially duplicatable.SILInstruction::clonedoesn't know how to clone instructions that produce the archetype uuid.SILCloneris equipped to handle such instructions. Optimizations like LoopRotate useSILInstruction::cloneand will be incorrect for such instructions.rdar://130047619