[region-isolation] Improve async let errors to always use a new style error. #74869
Conversation
gottesmm
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
…n also work with TransferNonSendable versions of the error. This asserts only option is an option to make it quicker/easier to triage unknown pattern match errors by aborting when we emit it (allowing one to immediately drop into the debugger at that point). Previously, it only happened for errors in RegionAnalysis not in TransferNonSendable itself.
… not further sent into an actor isolated function to use a new style error. Just going through and fixing sending errors. rdar://130915737
…oved cleanup transfernonsendable_asynclet.swift. NFC.
|
@swift-ci smoke test |
| #ifndef NDEBUG | ||
| /// Global bool set only when asserts are enabled to ease debugging by causing | ||
| /// unknown pattern errors to cause an assert so we drop into the debugger. | ||
| extern bool AbortOnUnknownPatternMatchError; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
The code in TransferNonSendable.cpp that uses AbortOnUnknownPatternMatchError is not guarded by NDEBUG.
swift/lib/SILOptimizer/Mandatory/TransferNonSendable.cpp
Lines 681 to 684 in 3ccbcfe
swift/lib/SILOptimizer/Mandatory/TransferNonSendable.cpp
Lines 1098 to 1101 in 3ccbcfe
swift/lib/SILOptimizer/Mandatory/TransferNonSendable.cpp
Lines 1161 to 1164 in 3ccbcfe
swift/lib/SILOptimizer/Mandatory/TransferNonSendable.cpp
Lines 1651 to 1654 in 3ccbcfe
There was a problem hiding this comment.
@drodriguez Thanks for the report! I am fixing it here: #74911
Just doing a go over of some of the diagnostics.
rdar://130915737