Sema: Downgrade actor convenience initializer diagnostic to a warning in interfaces #74877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
kavon
approved these changes
Jul 1, 2024
… in interfaces. The `convenience` keyword is not accepted on actor initializers because the compiler infers this status automatically and actors cannot be subclassed. However, internally the compiler still computes whether an actor init is a convenience init and this implicit status has been leaking through accidentally in printed `.swiftinterface` files. This was noticed because in Swift 6 the presence of the keyword is diagnosed as an error, making `.swiftinterface` files unparseable for modules containing actors with convenience inits. For Swift 6, I'm just going to suppress the error in `.swiftinterface` files regardless of language mode. In future releases of the compiler, though, it can stop printing the `convenience` keyword on these inits altogether, though. Resolves rdar://130857256.
tshortli
force-pushed
the
module-interface-suppress-actor-convenience-init-diag
branch
from
8e4929b to
7cadb0b
Compare
|
@swift-ci please smoke test |
tshortli
deleted the
module-interface-suppress-actor-convenience-init-diag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conveniencekeyword is not accepted on actor initializers because the compiler infers this status automatically and actors cannot be subclassed. However, internally the compiler still computes whether an actor init is a convenience init and this implicit status has been leaking through accidentally in printed.swiftinterfacefiles. This was noticed because in Swift 6 the presence of the keyword is diagnosed as an error, making.swiftinterfacefiles unparseable for modules containing actors with convenience inits.For Swift 6, I'm just going to suppress the error in
.swiftinterfacefiles regardless of language mode. In future releases of the compiler, though, it can stop printing theconveniencekeyword on these inits altogether.Resolves rdar://130857256.