[6.0] Deserializer: flush the diag engine to see a function type mismatch error #74898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Jul 2, 2024
eeckstein
commented
- Explanation: Fixes a not-printed error message. When such an error occurs the compiler just terminated with an exit code but not with an error message.
- Risk: Very low. The change only affects how this specific error message in the de-serializer is printed.
- Testing: Tested by a test case
- Issue: rdar://127767886
- Reviewer: @kubamracek
- Main branch PR: Deserializer: flush the diag engine to see a function type mismatch error #73565
eeckstein
force-pushed
the
fix-error-message-6.0
branch
from
b96298a to
50a9bd3
Compare
|
@swift-ci test |
tbkka
approved these changes
Jul 2, 2024
kubamracek
approved these changes
Jul 2, 2024
eeckstein
force-pushed
the
fix-error-message-6.0
branch
from
50a9bd3 to
45c61ab
Compare
|
@swift-ci test |
…rror Fixes a not-printed error message. rdar://127767886
eeckstein
force-pushed
the
fix-error-message-6.0
branch
from
45c61ab to
7d38cb9
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.