-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Various cleanups to definitions in the runtime #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -21,6 +21,18 @@ | |||
// Clang has been defining __INTxx_TYPE__ macros for a long time. | |||
// __UINTxx_TYPE__ are defined only since Clang 3.5. | |||
|
|||
#if defined(_WIN32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is _WIN32
the right check here? I was expecting a check for clang versus MSVC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, if the __INT_TYPE__
versions are a Darwin-specific workaround then they should be behind an affirmative check for Darwin. Then everyone else defaults to the cleaner stdint.h form.
#endif | ||
|
||
#if !defined(__has_attribute) | ||
#define __has_attribute(x) 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, we have to define these here, as these are installed headers - we don't want to rely on external LLVM files here.
Here is the very odd Linux error..
Looks like a bug? |
@swift-ci please smoke test@swift-ci please smoke test |
Looks good. |
@gparker42
Commit 1:
Commit 2:
Commit 3: