Skip to content

[6.0] [Completion] Handle body macro attribute completion #74906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

hamishknight
Copy link
Contributor

6.0 cherry-pick of #74888

  • Explanation: Adds completion support for function body macro attributes on function decls
  • Scope: Affects attribute code completion
  • Issue: rdar://130740590
  • Risk: Low, only affects code completion, and is fairly straightforward
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

Add support for function-attached macros, and
complete body and preamble macros in those
positions.

rdar://130740590
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels Jul 2, 2024
@hamishknight hamishknight requested a review from bnbarham July 2, 2024 20:19
@hamishknight hamishknight requested a review from a team as a code owner July 2, 2024 20:19
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 907bb90 into swiftlang:release/6.0 Jul 3, 2024
5 checks passed
@hamishknight hamishknight deleted the body-attr-6.0 branch July 3, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants