[Distributed] Correct tbd handling for distributed thunks #74935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jul 3, 2024
ktoso
commented
Jul 3, 2024
ktoso
force-pushed
the
wip-distributed-tbd-fixes
branch
from
4c40c12 to
068bfa0
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
ktoso
commented
Jul 23, 2024
|
@swift-ci please smoke test |
This avoids duplicate definitions and crashes when distributed thunks are used with protocols, and library evolution mode. Still problems remain with pedantic tbd validation. Resolves: edar://128310903
ktoso
force-pushed
the
wip-distributed-tbd-fixes
branch
from
2c865b6 to
c7e6f4a
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-tbd-fixes
branch
from
c7e6f4a to
0867b9a
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-tbd-fixes
branch
from
0867b9a to
9644e5c
Compare
care about macOS in this test in any case
ktoso
force-pushed
the
wip-distributed-tbd-fixes
branch
from
9644e5c to
43a17f5
Compare
|
@swift-ci please smoke test |
|
Ok additional testing seems to confirm we're good across resilient libraries here, going to merge and verify some more. |
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
Apr 18, 2025
…ust work This corrects how we were dealing with dispatch thunks -- mostly be removing a lot of special casing we did but doesn't seem necessary and instead we correct and emit all the necessary information int TBD, which resolves swiftlang#74935 or rather rdar://128310903 as well as rdar://128284016 but more correctly. regression test for rdar://145292018 resolves rdar://145292018 Fixes HOW we resolve: resolves rdar://128284016 resolves rdar://128310903
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
Apr 18, 2025
…ust work This corrects how we were dealing with dispatch thunks -- mostly be removing a lot of special casing we did but doesn't seem necessary and instead we correct and emit all the necessary information int TBD. This builds on swiftlang#74935 by further refining how we fixed that issue, and adds more regression tests. It also removes a load of special casing of distributed thunks in library evolution mode, which is great. Resolves and adds regression test for for rdar://145292018 This is also a more proper fix to the previously resolved but in a not-great-way which caused other issues: - resolves rdar://128284016 - resolves rdar://128310903
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
Apr 21, 2025
…ust work This corrects how we were dealing with dispatch thunks -- mostly be removing a lot of special casing we did but doesn't seem necessary and instead we correct and emit all the necessary information int TBD. This builds on swiftlang#74935 by further refining how we fixed that issue, and adds more regression tests. It also removes a load of special casing of distributed thunks in library evolution mode, which is great. Resolves and adds regression test for for rdar://145292018 This is also a more proper fix to the previously resolved but in a not-great-way which caused other issues: - resolves rdar://128284016 - resolves rdar://128310903 Review followup, cleanup test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplicate definitions and crashes when distributed thunks are used with protocols, and library evolution mode.
Still problems remain with pedantic tbd validation.
Thanks @xedin for the help digging through this