[6.0] Change interface printing behaviors for -package-name and -project-name
#74940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having package-name flag in non-package interfaces causes them to be built as if belonging to a package, which causes an issue for a loading client outside of the package as follows. For example, when building X that depends on A with the following dependency chain: X --> A --> B --(package-only)--> C 1. X itself is not in the same package as A, B, and C. 2. When dependency scanning X, and opening up B, because the scan target is in a different package domain, the scanner decides that B's package-only dependency on C is to be ignored. 3. When then finally building A itself, it will load its dependencies, but because the .private.swiftinterface of A still specifies -package-name, when it loads B, it will then examine its dependencies and deem that this package-only dependency on C is required. Because (2) and (3) disagree, we get an error now when building the private A textual interface. rdar://130701866
There are two axes on which a saved frontend flag can be categorized for printing in a `.swiftinterface` file: 1. Whether the flag is "ignorable" or not. 2. Which levels of interface the flag should be in (public, package). This refactor ensures that those two axes are modeled independently and prepares the infrastructure to allow flags to appear in the private and package interfaces without being included in the public interface.
…terfaces. Resolves rdar://130992944.
|
@swift-ci please test |
tshortli
changed the title
-package-name and -project-name
tbkka
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-package-nameflag in the package.swiftinterface. The second change always excludes the-project-nameflag from the public.swiftinterfacefile for a module, while continuing to print it in the private and package interfaces. These changes are bundled because they are related and one builds on top of the other..swiftinterfaceprinting when the-package-nameand-project-nameflags are specified.-project-namein private and package interfaces #74921.swiftinterfacefiles works in general.