Skip to content

[cxx-interop] Emit Swift StdLib dependencies when all public decls emitted #74942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Xazax-hun
Copy link
Contributor

The generated header would not compile without these dependencies. Moreover users probably expect all-public option to be the most permissive filter including the maximal amount of declarations.

…itted

The generated header would not compile without these dependencies. Moreover
users probably expect all-public option to be the most permissive filter
including the maximal amount of declarations.
@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Jul 3, 2024
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

@Xazax-hun Xazax-hun enabled auto-merge July 4, 2024 10:02
@Xazax-hun Xazax-hun merged commit 3ee8272 into main Jul 4, 2024
3 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/emit-implicit-std-dependencies-all-public branch July 4, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants