-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add some diagnostics related to lifetime dependence and function types #74956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// RUN: %target-typecheck-verify-swift -enable-experimental-feature NonescapableTypes | ||
// REQUIRES: asserts | ||
|
||
struct NC: ~Copyable { | ||
var ne: NE { | ||
NE() | ||
} | ||
} | ||
|
||
struct NE: ~Escapable { | ||
@_unsafeNonescapableResult | ||
init() {} | ||
} | ||
|
||
func transfer(_ ne: NE) -> NE { | ||
ne | ||
} | ||
|
||
func applyAnnotatedTransfer(ne: NE, transfer: (NE) -> dependsOn(0) NE) -> NE { // expected-error{{lifetime dependencies on function types are not supported}} | ||
transfer(ne) | ||
} | ||
|
||
func applyTransfer(ne: NE, transfer: (NE) -> NE) -> NE { | ||
transfer(ne) | ||
} | ||
|
||
func testTransfer(nc: consuming NC) { | ||
let transferred = applyTransfer(ne: nc.ne, transfer: transfer) // expected-error{{cannot convert value of type '(NE) -> _inherit(0) NE' to expected argument type '(NE) -> NE'}} | ||
|
||
_ = consume nc | ||
_ = transfer(transferred) | ||
} | ||
|
||
func borrow(_ nc: borrowing NC) -> NE { | ||
nc.ne | ||
} | ||
|
||
func applyBorrow(nc: borrowing NC, borrow: (borrowing NC) -> NE) -> NE { | ||
borrow(nc) | ||
} | ||
|
||
func testBorrow(nc: consuming NC) { | ||
let borrowed = applyBorrow(nc: nc, borrow: borrow) // expected-error{{cannot convert value of type '(borrowing NC) -> _scope(0) NE' to expected argument type '(borrowing NC) -> NE}} | ||
_ = consume nc | ||
_ = transfer(borrowed) | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works because the solver would use a "catch all" conversion fix for arguments but maybe we should add a tailored fix for this to indicate what really mismatched here instead of making developers compare types visually and guess?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting to use a
ContextualFailure
? I didn't see precedent in CSSimplify where aContextualFailure
was used without attempting aConstraintFix
. Most type mismatches withoutConstraintFix
were flagged with the genericgetTypeMatchFailure
.If it is okay to use a
ContextualFailure
here, I can do that as a follow on PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really want to implement a
ConstraintFix
here. It can cause cascaded SIL diagnostics later on and maybe even more confusing to the user.