Skip to content

[Concurrency] Attempt to unbreak embedded build #75006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jul 6, 2024

Various #ifs overlapping made this work in other places, but not here.

No idea why this previously worked, some configuration must have changed? This code was here for like a year.

@kubamracek might have some ideas

@ktoso
Copy link
Contributor Author

ktoso commented Jul 6, 2024

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Jul 6, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset
@swift-ci please smoke test

@ktoso ktoso requested a review from kubamracek July 6, 2024 01:56
@ktoso ktoso changed the title [Concurrency] Attempt to unbreak embedded build [Embedded] Attempt to unbreak embedded build Jul 6, 2024
@ktoso ktoso changed the title [Embedded] Attempt to unbreak embedded build [Concurrency] Attempt to unbreak embedded build Jul 6, 2024
@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features embedded Embedded Swift labels Jul 6, 2024
@ktoso ktoso merged commit df43b63 into swiftlang:main Jul 8, 2024
3 checks passed
@ktoso ktoso deleted the wip-embedded-unbreak branch July 8, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features embedded Embedded Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant