-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Adopt SwiftIfConfig library to help with #if
clause handling
#75014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DougGregor
merged 8 commits into
swiftlang:main
from
DougGregor:swiftifconfig-build-configuration
Aug 6, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5c3b777
Implement a SwiftIfConfig.BuildConfiguration that queries the ASTContext
DougGregor d06e408
Re-implement SourceFile::getIfConfigClauseRanges on top of SwiftIfConfig
DougGregor ca588b7
Insert `#endif` directives into `#if` config ranges list produced by …
DougGregor ddbbb5a
Address code review comments and build failure
DougGregor 0c9a8a8
Sink implementation of SourceFile::getIfConfigClauseRanges into Sema
DougGregor a844f4f
Free memory allocated in Swift from Swift, not C++
DougGregor d686a3e
Handle `$FeatureName` custom conditions in CompilerBuildConfiguration
DougGregor cfd0a3f
Thread a source location through canImport evaluation in CompilerBuil…
DougGregor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
//===--- IfConfigClauseRangeInfo.h - header for #if clauses -=====---------===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2022 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef SWIFT_AST_IFCONFIGCLAUSERANGEINFO_H | ||
#define SWIFT_AST_IFCONFIGCLAUSERANGEINFO_H | ||
|
||
#include "swift/Basic/SourceLoc.h" | ||
|
||
namespace swift { | ||
|
||
class SourceManager; | ||
|
||
/// Stores range information for a \c #if block in a SourceFile. | ||
class IfConfigClauseRangeInfo final { | ||
public: | ||
enum ClauseKind { | ||
// Active '#if', '#elseif', or '#else' clause. | ||
ActiveClause, | ||
// Inactive '#if', '#elseif', or '#else' clause. | ||
InactiveClause, | ||
// '#endif' directive. | ||
EndDirective, | ||
}; | ||
|
||
private: | ||
/// Source location of '#if', '#elseif', etc. | ||
SourceLoc DirectiveLoc; | ||
/// Character source location of body starts. | ||
SourceLoc BodyLoc; | ||
/// Location of the end of the body. | ||
SourceLoc EndLoc; | ||
|
||
ClauseKind Kind; | ||
|
||
public: | ||
IfConfigClauseRangeInfo(SourceLoc DirectiveLoc, SourceLoc BodyLoc, | ||
SourceLoc EndLoc, ClauseKind Kind) | ||
: DirectiveLoc(DirectiveLoc), BodyLoc(BodyLoc), EndLoc(EndLoc), | ||
Kind(Kind) { | ||
assert(DirectiveLoc.isValid() && BodyLoc.isValid() && EndLoc.isValid()); | ||
} | ||
|
||
SourceLoc getStartLoc() const { return DirectiveLoc; } | ||
CharSourceRange getDirectiveRange(const SourceManager &SM) const; | ||
CharSourceRange getWholeRange(const SourceManager &SM) const; | ||
CharSourceRange getBodyRange(const SourceManager &SM) const; | ||
|
||
ClauseKind getKind() const { return Kind; } | ||
}; | ||
|
||
} | ||
|
||
#endif /* SWIFT_AST_IFCONFIGCLAUSERANGEINFO_H */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.