Skip to content

[cxx-interop] Adjust two IRGen tests for rebranch #75056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

egorzhdan
Copy link
Contributor

This fixes Interop/Cxx/class/returns-large-class-irgen.swift by adjusting the expected function signature.

On rebranch, the actual signature is:

define void @_Z21funcReturnsLargeClassv(ptr dead_on_unwind noalias writable sret(%struct.LargeClass) align 8 %agg.result)

rdar://127263407

This fixes `Interop/Cxx/class/returns-large-class-irgen.swift` by adjusting the expected function signature.

On rebranch, the actual signature is:
```
define void @_Z21funcReturnsLargeClassv(ptr dead_on_unwind noalias writable sret(%struct.LargeClass) align 8 %agg.result)
```

rdar://127263407
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jul 8, 2024
@egorzhdan egorzhdan requested review from Xazax-hun and ahatanaka July 8, 2024 12:45
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners July 8, 2024 12:45
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan enabled auto-merge July 8, 2024 12:46
This fixes `Interop/Cxx/class/method/methods-this-and-indirect-return-irgen-itanium.swift` by adjusting the expected function signature.

On rebranch, the actual signature is:
```
define linkonce_odr void @_ZN10HasMethods28nonConstPassThroughAsWrapperEi(ptr dead_on_unwind noalias writable sret(%struct.NonTrivialInWrapper) align 4 %agg.result, ptr noundef nonnull align 1 dereferenceable(1) %this, i32 noundef %a)
```

rdar://127263407
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan changed the title [cxx-interop] Adjust an IRGen test for rebranch [cxx-interop] Adjust two IRGen tests for rebranch Jul 8, 2024
Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egorzhdan egorzhdan merged commit c8d06ef into main Jul 8, 2024
4 of 5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/rebranch-large-irgen-test branch July 8, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants