Skip to content

[cxx-interop] Adjust a concepts test for rebranch #75065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

egorzhdan
Copy link
Contributor

Clang now includes concepts in the mangled names of C++ functions: swiftlang/llvm-project@4b163e3

This adjusts the test to verify that we don't transitively emit the symbols referenced from the requires expression. Those symbols shouldn't be emitted because they are not executed.

rdar://127263407

Clang now includes concepts in the mangled names of C++ functions: swiftlang/llvm-project@4b163e3

This adjusts the test to verify that we don't transitively emit the symbols referenced from the requires expression. Those symbols shouldn't be emitted because they are not executed.

rdar://127263407
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jul 8, 2024
@egorzhdan egorzhdan requested a review from Xazax-hun July 8, 2024 17:00
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners July 8, 2024 17:00
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test macOS

@egorzhdan egorzhdan merged commit 535ea97 into main Jul 9, 2024
4 of 5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/rebranch-concepts-test branch July 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants