Skip to content

[6.0] Move main/6.0 windows Foundation builds to separate branch (#75073) #75092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmschonfeld
Copy link
Contributor

Cherry pick of #75073

Explanation: Adds a new swift-corelibs-foundation checkout of the windows/* branch and updates the windows build script to use this checkout
Scope: Affects building Foundation on windows
Original PR: #75073
Risk: Minimal - this should have no impact until the standard and windows/* branches diverge
Testing: Testing done via swift-ci testing
Reviewer: @parkera

@jmschonfeld jmschonfeld requested a review from a team as a code owner July 9, 2024 02:37
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld enabled auto-merge (squash) July 9, 2024 02:37
@shahmishal
Copy link
Member

How long do we plan to maintain the two branches of swift-corelibs-foundation? This will pose an issue when tagging both the nightly and release, unless we establish a different tagging scheme for the Windows branch.

@jmschonfeld jmschonfeld disabled auto-merge July 9, 2024 05:20
@jmschonfeld
Copy link
Contributor Author

Closing now that this is no longer necessary and is being reverted from main

@jmschonfeld jmschonfeld deleted the isolate-windows-foundation-build-6.0 branch July 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants