Skip to content

utils: pin the latest build for ARM64 to bootstrap on Windows #75104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jul 9, 2024

We need a bootstrapping toolchain. Now that we have an ARM64 build for Windows, pin that to provide a default pinned toolchain. This should allow us to build natively on Windows ARM64 without having to specify the download image ourselves.

We need a bootstrapping toolchain. Now that we have an ARM64 build for
Windows, pin that to provide a default pinned toolchain. This should
allow us to build natively on Windows ARM64 without having to specify
the download image ourselves.
@compnerd compnerd requested review from hyp, shahmishal and hjyamauchi July 9, 2024 16:49
@compnerd
Copy link
Member Author

compnerd commented Jul 9, 2024

@swift-ci please test

@compnerd compnerd requested a review from etcwilde July 9, 2024 17:11
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with pinning it, though I'd like confirmation that someone tried out the pinned toolchain and made sure that it's viable and produces binaries without crashing before approving. I don't have an arm64 windows box to test with unfortunately.

This should allow us to build natively on Windows ARM64

Does this mean you've tried it and it worked or that it looks like it should work?

@compnerd
Copy link
Member Author

compnerd commented Jul 9, 2024

I'm fine with pinning it, though I'd like confirmation that someone tried out the pinned toolchain and made sure that it's viable and produces binaries without crashing before approving. I don't have an arm64 windows box to test with unfortunately.

Yes, the pinned ARM64 toolchain was smoke tested and does generate working binaries.

Does this mean you've tried it and it worked or that it looks like it should work?

I do not have a ARM64 machine capable of building the toolchain. Perhaps someone at Apple can do that under parallels if we want to test this particular revision of the toolchain? The native ARM64 toolchain build path has been tested by @hjyamauchi repeatedly though.

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The native ARM64 toolchain build path has been tested by @hjyamauchi repeatedly though.

Good enough for me.

@hjyamauchi
Copy link
Contributor

Also the pinned toolchain is used during the CI build so if it doesn't work the CI should fail.

@compnerd compnerd merged commit 31fc0a6 into swiftlang:main Jul 10, 2024
5 checks passed
@compnerd compnerd deleted the pinning branch July 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants