AST: Fix excessive deserialization in GenericSignatureBuilder #7513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we're looking up all associated types with the same name in order to find the right archetype anchor, skip extension members to avoid circular deserialization. Discovered while investigating <rdar://problem/30248571>.
|
@swift-ci Please smoke test |
|
I think we may be hitting the assert deterministically now! Baby steps. cc @DougGregor |
|
I'm going to revert for now since hitting the assert more often means everyone is blocked. But it seems like it'll help us with tracking down the real error. |
|
My attempt at reinstating this is at #7530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're looking up all associated types with the same name in order
to find the right archetype anchor, skip extension members to avoid
circular deserialization.
Discovered while investigating rdar://problem/30248571.