Skip to content

[cxx-interop] Export accessors of static properties to C++ #75202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Xazax-hun
Copy link
Contributor

@Xazax-hun Xazax-hun commented Jul 12, 2024

The code wants to avoid exporting certain synthesized operators but it inadvertently also prevented exporting accessors to static properties. Fixes #70338.

rdar://115564118

The code wants to avoid exporting certain synthesized operators but it
inadvertently also prevented exporting accessors to static properties.

rdar://115564118
@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Jul 12, 2024
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xazax-hun
Copy link
Contributor Author

Looks like there was an unrelated failure.

@swift-ci please smoke test macOS

@Xazax-hun Xazax-hun enabled auto-merge July 15, 2024 09:45
@Xazax-hun Xazax-hun merged commit 01bd2b4 into main Jul 15, 2024
3 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/export-static-properties branch July 15, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ interop: generated header is missing static property in a class
2 participants