-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test] Generalize runtime library searching #75207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Generalize runtime library searching #75207
Conversation
2e04d65
to
03b2bed
Compare
03b2bed
to
ac670e3
Compare
Allow detecting the compiler runtime libraries for non-Darwin platforms, allowing us to test that programs relying on these libraries link successfully.
ac670e3
to
251182c
Compare
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a nice cleanup. It would be nice to ensure that we also print the swift resource directory in addition to the clang one that you've cleaned up.
I might be misunderstanding, but we should already be doing that: Line 379 in 251182c
|
Ah, is just shuffled, so all good! |
@@ -21,6 +21,9 @@ | |||
// REQUIRES: profile_runtime | |||
// REQUIRES: executable_test | |||
|
|||
// FIXME: Currently fails on non-Darwin (https://github.com/swiftlang/swift/issues/75240) | |||
// REQUIRES: OS=macosx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this affected by the changes in this patch? It looks unrelated to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because we're now running this test on non-Darwin platforms, previously we wouldn't have picked up the profile_runtime
feature
Allow detecting the compiler runtime libraries for non-Darwin platforms, allowing us to test that programs relying on these libraries link and run successfully.