[Sema] Allow @_section/@_used in concrete generic context #75222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
requested review from
rjmccall,
hborla,
slavapestov and
xedin
as code owners
kastiglione
changed the title
|
@swift-ci smoke test |
slavapestov
approved these changes
Jul 12, 2024
|
@swift-ci test macOS |
|
@swift-ci smoke test macOS |
kastiglione
deleted the
dl/Sema-Allow-_section-_used-in-concrete-generic-context
branch
kastiglione
added a commit
that referenced
this pull request
Jul 16, 2024
Allow `@_section` and `@_used` to be used in fully constrained extensions.
This aligns with the existing behavior of static properties of generic types. The following is valid:
```swift
extension Array where Element == Int {
static let specificConstant = 41
}
```
However, adding `@_section` or `@_used` to the above property, will result in an error diagnostic.
This change updates the logic of `@_section`/`@_used` to allow their use when the generic context is fully concrete.
(cherry picked from commit ad8b0f3)
kastiglione
added a commit
that referenced
this pull request
Jul 17, 2024
…75277) Allow `@_section` and `@_used` to be used in fully constrained extensions. This aligns with the existing behavior of static properties of generic types. The following is valid: ```swift extension Array where Element == Int { static let specificConstant = 41 } ``` However, adding `@_section` or `@_used` to the above property, will result in an error diagnostic. This change updates the logic of `@_section`/`@_used` to allow their use when the generic context is fully concrete. (cherry picked from commit ad8b0f3)
susmonteiro
pushed a commit
that referenced
this pull request
Jul 19, 2024
Allow `@_section` and `@_used` to be used in fully constrained extensions.
This aligns with the existing behavior of static properties of generic types. The following is valid:
```swift
extension Array where Element == Int {
static let specificConstant = 41
}
```
However, adding `@_section` or `@_used` to the above property, will result in an error diagnostic.
This change updates the logic of `@_section`/`@_used` to allow their use when the generic context is fully concrete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
@_sectionand@_usedto be used in fully constrained extensions.This aligns with the existing behavior of static properties of generic types. The following is valid:
However, adding
@_sectionor@_usedto the above property, will result in an error diagnostic.This change updates the logic of
@_section/@_usedto allow their use when the generic context is fully concrete.