Skip to content

Change note for non marked with main actor global variables #75235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2024
Merged

Change note for non marked with main actor global variables #75235

merged 1 commit into from
Jul 20, 2024

Conversation

rofle100lvl
Copy link
Contributor

Resolves #74751

  • Changed note
  • Changed tests

@rofle100lvl
Copy link
Contributor Author

rofle100lvl commented Jul 15, 2024 •
edited
Loading

@swift-ci please test
UPD: Well I got it. It looks like I haven't permission to start test flow

hborla
hborla reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left a suggestion inline

@rofle100lvl rofle100lvl requested a review from hborla July 18, 2024 07:46
@rofle100lvl rofle100lvl force-pushed the change_note_main_actor_variables branch from 2a38ba0 to 2be10bb Compare July 20, 2024 00:23
@rofle100lvl rofle100lvl force-pushed the change_note_main_actor_variables branch from 2be10bb to 2c1e45a Compare July 20, 2024 00:39
hborla
hborla approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hborla
Copy link
Member

hborla commented Jul 20, 2024

@swift-ci please smoke test

@hborla hborla merged commit ee2dd82 into swiftlang:main Jul 20, 2024
3 checks passed
@AnthonyLatsis AnthonyLatsis mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presentation different for identical concurrency note
2 participants
@rofle100lvl @hborla