Extend _unsafeInheritExecutor_ to remaining @_unsafeInheritExecutor APIs #75248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
hborla
approved these changes
Jul 15, 2024
Extend the _unsafeInheritExecutor_ workaround to all remaining APIs in the Concurrency library that have adopted `#isolation` default arguments to (safely) stay in the caller's isolation domain... ... except one. Clock.measure() is currently running into problems with the type checker workaround and needs a little more thought. Fixes rdar://131760111.
…ecutor_ functions When inside the concurrency library, suppress the diagnostics about use of the (deprecated) `@_unsafeInheritExecutor` for functions whose names start with the "_unsafeInheritExecutor_" prefix that's used for compatibility. This focuses the diagnostic on those places in the concurrency library that might still need to introduce this hack.
DougGregor
force-pushed
the
unsafe-inherit-executor-the-rest
branch
from
470d5c1 to
a47483c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the unsafeInheritExecutor workaround to all remaining APIs in the Concurrency library that have adopted
#isolationdefault arguments to (safely) stay in the caller's isolation domain...... except one. Clock.measure() is currently running into problems with the type checker workaround and needs a little more thought.
Fixes rdar://131760111.