Add precondition to prevent out-of-bounds access #75266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/cxx-precondition-oob
branch
2 times, most recently
from
9a0bb31 to
2ddbb0c
Compare
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/cxx-precondition-oob
branch
from
2ddbb0c to
1085146
Compare
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/cxx-precondition-oob
branch
from
1085146 to
fd0c0cd
Compare
|
@swift-ci please smoke test |
The subscript function from CxxRandomAccessCollection did not perform any bounds-checks. This means that C++ containers that don't provide the operator[] (or C++ containers used in generic contexts) didn't have bounds-checks. Fixes rdar://126570011
susmonteiro
force-pushed
the
susmonteiro/cxx-precondition-oob
branch
from
fd0c0cd to
15e1749
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subscriptfunction fromCxxRandomAccessCollectiondid not perform any bounds-checks.This means that C++ containers that don't provide the
operator[](or C++ containers used in generic contexts) didn't have bounds-checks.Fixes rdar://126570011