Skip to content

[Mem2Reg] Bail on address-only types. #75292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Jul 17, 2024

It is impossible to have a value of address-only type, so don't try promoting.

rdar://131882748

@nate-chandler nate-chandler requested a review from eeckstein as a code owner July 17, 2024 15:10
It is impossible to have a value of address-only type, so don't try
promoting.

rdar://131882748
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler nate-chandler requested a review from atrick July 17, 2024 15:12
@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci Please Test Source Compatibility Release

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So that's how you do resilient types in a test case.

@nate-chandler nate-chandler merged commit e9279e2 into swiftlang:main Jul 18, 2024
8 checks passed
@nate-chandler nate-chandler deleted the rdar131882748 branch July 18, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants