Skip to content

[6.0] [Sema] Let protocols define getter requirements for @_staticExclusiveOnly types #75296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jul 17, 2024

This is a cherry pick of #74901

  • Explanation: Allows for protocol requirements to declare getters with @_staticExclusiveOnly types.
  • Main Branch PR: [Sema] Let protocols define getter requirements for @_staticExclusiveOnly types #74901
  • Resolves: rdar://130447812
  • Risk: Low because this code path was only exercised for @_staticExclusiveOnly types which is only Atomic and Mutex at the moment. Previously code that was attempting to use these types as getter requirements did not compile and this change fixes this codepath so that those use cases are now allowed.
  • Reviewed By: @tshortli @hamishknight
  • Testing: Existing test-cases were modified and new tests were added.

…ments

[Sema] Let protocols define getter requirements for @_staticExclusiveOnly types
@Azoy Azoy requested a review from a team as a code owner July 17, 2024 15:33
@Azoy
Copy link
Contributor Author

Azoy commented Jul 17, 2024

@swift-ci please test

@Azoy Azoy merged commit 3db75bd into swiftlang:release/6.0 Jul 17, 2024
5 checks passed
@Azoy Azoy deleted the 60-static-exclusive-requirements branch July 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants