[utils] Remove wildcard imports #753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From PEP 0008: > Wildcard imports (`from <module> import *`) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools. Using a wildcard import in `utils/build-script` makes it difficult to understand which exported functions from `SwiftBuildSupport.py` are actually being used. Remove the wildcard in favor of an explicit, multi-line import.
From PEP 0008: > Wildcard imports (`from <module> import *`) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools. Using a wildcard import in `utils/update-checkout` makes it difficult to understand which exported functions from `SwiftBuildSupport.py` are actually being used. Remove the wildcard in favor of an explicit, multi-line import.
From PEP 0008: > Wildcard imports (`from <module> import *`) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools. Using a wildcard import in `utils/recursive-lipo` makes it difficult to understand which exported functions from `SwiftBuildSupport.py` are actually being used. In reality, only one function is used, so import it explicitly.
|
Oops! Turns out I largely duplicated work simultaneously being done in #752. I'll close this pull request in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PEP 0008:
Using wildcard imports for
SwiftBuildSupport.pymakes it difficult to understand which exported functions are actually being used. These commits make this clearer--in some cases, it reveals that only one symbol is being used, or in the case of #751, that a function is never used at all.