[Debug] Escape LLDB syntax in debugDescription #75300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
stephentyrone
approved these changes
Jul 17, 2024
hborla
requested changes
Jul 17, 2024
hborla
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
@DebugDescription, only allow use of LLDB Summary Strings syntax fromlldbDescriptionproperties. When@DebugDescriptionis applied to existingdebugDescriptionproperties, escape any$, as the output ofdebugDescriptionis never interpreted by LLDB.This will not break existing code. Adopters will almost certainly be unaffected.
[Debug] Escape LLDB syntax in debugDescription #75300
No risk, it fixes a potentially surprising bug if an existing
debugDescriptionwas reused with this macro, and the string contained the substring${.Swift tests, CI.
@hborla, @stephentyrone, @DougGregor