[Distributed] Handle #isolation param in DA as known to not cross isolation #75327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jul 18, 2024
| @@ -548,7 +548,7 @@ extension ActorAddress { | |||
| return bytes | |||
| } | |||
| func fromBytes(_ bytes: [UInt8]) throws -> ActorAddress { | |||
| let address = String(cString: bytes) | |||
There was a problem hiding this comment.
killed off a new deprecation warning while at it
ktoso
commented
Jul 18, 2024
| // as otherwise we don't know where the value came from and if it's really | ||
| // self we're calling from; We'd need more sophisticated analysis to make it work. | ||
| // let myself = self.asLocalActor | ||
| // pass(isolatedToActor: myself) // same |
There was a problem hiding this comment.
so we can't support this yet... which is fine; the primary usecase is #isolation's default value
ktoso
force-pushed
the
wip-self-isolation-passing-for-distributed
branch
from
7f7ca53 to
bbf75d1
Compare
|
@swift-ci please smoke test |
ktoso
added
distributed
…lation The isolation checker was assuming that one can only be isolated to a specific var, but that's not true for distributed actors -- because the default parameter emitted by #isolation is a method call -- converting the self into an any Actor. We must handle this in isolation checker in order to avoid thinking we're crossing isolation boundaries and making methods implicitly async etc, when we're actually not. resolves rdar://131874709
ktoso
force-pushed
the
wip-self-isolation-passing-for-distributed
branch
from
bbf75d1 to
ddaba86
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isolation checker was assuming that one can only be isolated to a specific var, but that's not true for distributed actors -- because the default parameter emitted by #isolation is a method call -- converting the self into an any Actor.
We must handle this in isolation checker in order to avoid thinking we're crossing isolation boundaries and making methods implicitly async etc, when we're actually not.
resolves rdar://131874709