Re-add ICU as a valid remote #75342
Merged
Re-add ICU as a valid remote #75342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I removed ICU, I removed it from the list of remotes and its branch from the
mainconfig, however therelease/6.0config still needs this remote and it turns out that when running tests on repos other than the swiftlang/swift repo, CI checks out themainbranch of the swift repo and runs update-checkout from that to update the checkout torelease/6.0. This means that we still need ICU as a valid remote on themainbranch, but we can leave it out of the list of repos for themainobject in the JSON file so it doesn't get checked out when building against the "main" scheme