Platform: add UserEnv module to WinSDK #75362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows access to the `GetUserProfileDirectoryW` API which is required for the swift-foundation implementation on Windows. (cherry picked from commit 5919346)
|
@swift-ci please test |
parkera
approved these changes
Jul 19, 2024
shahmishal
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows access to the
GetUserProfileDirectoryWAPI which is required for the swift-foundation implementation on Windows.(cherry picked from commit 5919346)
Explanation: Add a new submodule for API access on Windows
Scope: This impacts only the WinSDK module, which is Windows specific.
Issue:
Original PR: #73008
Risk: If the WinSDK module is not tested, it could result in the module breaking which would make Swift nearly unusable on Windows.
Testing: CI testing which will build modules with WinSDK
Reviewer: @jmschonfeld