Tests: Drop maccatalyst_support requirement for several tests #75380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As much as possible, we should avoid using `REQUIRES: maccatalyst_support` since tests restricted this way are not run in PR tests. Many tests that exercise macCatalyst behaviors can be run in a macOS configuration, without full macCatalyst standard library support. Also, adopt `%target-cpu` lit substitution where appropriate to avoid needless standard library module rebuilds when running tests locally.
tshortli
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin,
CodaFi and
DougGregor
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as possible, we should avoid using
REQUIRES: maccatalyst_supportsince tests restricted this way are not run in PR tests. Many tests that exercise macCatalyst behaviors can be run in a macOS configuration, without full macCatalyst standard library support.Also, adopt
%target-cpulit substitution where appropriate to avoid needless standard library module rebuilds when running tests locally.