Skip to content

[cxx-interop] Support generic types with isValueType trait #75396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Xazax-hun
Copy link
Contributor

In some circumstances the missing trait resulted in picking the wrong branch of some compile time conditionals resulting in code that would not compile.

rdar://126709253

@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Jul 22, 2024
@Xazax-hun Xazax-hun marked this pull request as ready for review July 22, 2024 15:30
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

In some circumstances the missing trait resulted in picking the wrong
branch of some compile time conditionals resulting in code that would
not compile.

rdar://126709253
@Xazax-hun Xazax-hun force-pushed the gaborh/value-type-trait branch from f4ebef9 to 48ebed6 Compare July 23, 2024 07:49
@Xazax-hun
Copy link
Contributor Author

I had to do a small test change to make Windows CI happy.

@swift-ci please smoke test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xazax-hun
Copy link
Contributor Author

Linux failure seems to be unrelated, rerunning.

@swift-ci please smoke test linux

@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test linux

@Xazax-hun Xazax-hun enabled auto-merge July 24, 2024 07:50
@Xazax-hun Xazax-hun merged commit 536a889 into main Jul 24, 2024
3 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/value-type-trait branch July 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants