Fix LifetimeDependenceDiagnostics to handle invalid SIL types #75428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid types are not considered Escapable. This makes it difficult to make any assumptions about nonescapable types. Fixes rdar://132348528 (Fix LifetimeDependenceDiagnostics to handle invalid SIL types)
|
@swift-ci test |
tshortli
approved these changes
Jul 23, 2024
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 12, 2024
In lazy typechecking mode, errors in the program may only be discovered during SILGen, which can leave the SIL in a bad state for subsequent stages of compilation. If errors were detected, skip SIL verification and optimization to prevent knock-on failures. Partially reverts swiftlang#75428, which included a more targeted fix for one of the possible knock-on effects of bad SIL coming out of SILGen. Resolves rdar://132107752.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid types are not considered Escapable. This makes it difficult to make any assumptions about nonescapable types.
Fixes rdar://132348528 (Fix LifetimeDependenceDiagnostics to handle invalid SIL types)