Upstream missing macCatalyst support #75432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream the necessary changes to compile `if #available` queries correctly when a `macabi` target triple or a `-target-variant` is specified.
Upstreams the necessary changes to compile references to `@backDeployed` declarations correctly when a `macabi` target triple or a `-target-variant` is specified.
Teach `inhibitsAllocStackHoisting` about the `targetVariantOSVersionAtLeast` and `targetOSVersionOrVariantOSVersionAtLeast` builtins.
tshortli
requested review from
a team,
xymus,
jckarter,
rjmccall,
hborla,
slavapestov,
xedin,
eeckstein,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 2, 2024
This test was missed in swiftlang#75432.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream various missing bits of macCatalyst platform support, primarily related to compiling availability checks (especially in zippered libraries).
For zippered binaries,
if #availablechecks will still ultimately be miscompiled because the necessary compiler-rt entry point is missing from llvm/clang (see theFIXMEin_stdlib_isOSVersionAtLeastOrVariantVersionAtLeast()). However, this otherwise brings parity with the Apple Swift compiler for code generation when targeting macCatalyst.Partly resolves rdar://103960437 and #62884.