[5.10] WalkUtils: handle unsafe_ref_cast which casts between AnyObject and a class
#75445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a class We need to ignore such casts because otherwise the constructed walking path wouldn't contain the right `existential` field kind. Fixes a miscompile caused by redundant load elimination. rdar://132364917 # Conflicts: # SwiftCompilerSources/Sources/Optimizer/Utilities/WalkUtils.swift # include/swift/SIL/SILBridging.h # include/swift/SIL/SILBridgingImpl.h # test/SILOptimizer/addr_escape_info.sil # test/SILOptimizer/redundant_load_elim.sil
|
@swift-ci test |
|
@swift-ci test windows |
tbkka
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnyObjectand a class is done with anunsafe_ref_castinstruction instead ofinit_existential_refandopen_existential_ref. This happens for example inunsafeDownCast. This is not handled correctly in escape analysis. Therefore optimizations, which use escape analysis, like redundant-load-elimination, can mis-compile such patterns.unsafeDownCastor similar unsafe cast utilities from the stdlib.unsafe_ref_castwhich casts between AnyObject and a class #75434