When ASAN is visible, do not use page-aligned requests #75454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
gottesmm
approved these changes
Jul 25, 2024
|
Phooey. This didn't work. I presume that means that ASAN testing only uses ASAN with the actual tests per se, not with the test support libraries. I'll just disable these tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75415 upsets ASAN. That PR sped up the RemoteMirror tests by having the target program return "pages" of memory data to the inspection test host. But that means we're reading blocks of memory that span allocated and de-allocated regions which ASAN finds problematic.
So this test just disables that optimization when building for ASAN. Instead, the test host only requests specific small amounts of memory that it needs to analyze specific types and/or values. These requests should never touch deallocated areas of memory so should never upset ASAN.
Resolves rdar://132424309