Skip to content

[6.0] Run moveonly checker + TSAN tests in a separate file. #75483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Jul 25, 2024

Explanation: Fixes a test failure in 6.0 CI.
Scope: Test fix, no change in compiler or runtime behavior
Issue: rdar://129286269
Original PR: #74270
Risk: Low. Test fix, no change in compiler or runtime behavior
Testing: Swift CI
Reviewed by: @eeckstein

TSAN is not supported on all targets, so covering TSAN in the same file as the
core tests makes them unnecessarily nonportable. rdar://129286269
@jckarter jckarter requested a review from a team as a code owner July 25, 2024 18:18
@jckarter
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eeckstein eeckstein merged commit dc55303 into swiftlang:release/6.0 Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants