AST: Fix MemberImportVisibility handling of @_exported imports
#75511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In existing Swift, an `@_exported import` in any source file makes the declarations from the imported module visible in all source files. It's unclear whether this is an explicit decision or is simply and unintended consequence of effectively adding an implicit import to each source file for the module being compiled. Although it's not clear whether this behavior is desirable, the behavior of member lookup when the MemberImportVisibility feature is enabled should align with it in order to avoid causing unnecessary churn in required imports. Resolves rdar://132525152.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
DougGregor
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In existing Swift, an
@_exported importin any source file makes the declarations from the imported module visible in all source files. It's unclear whether this is an explicit decision or is simply and unintended consequence of effectively adding an implicit import to each source file for the module being compiled.Although it's not clear whether this behavior is desirable, the behavior of member lookup when the
MemberImportVisibilityfeature is enabled should align with it in order to avoid causing unnecessary churn in required imports.Resolves rdar://132525152.