[Sema] Fold SequenceExpr in pre-checking pre-walk #75528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
foldable-tangent
branch
from
26afa19 to
9abc333
Compare
hamishknight
changed the title
hamishknight
force-pushed
the
foldable-tangent
branch
from
9abc333 to
3feeeac
Compare
Sink forbidden prefix and `init` recovery into `resolveDeclRefExpr`, and move diagnosis of `self` in an `init` accessor into the pre-checking post-walk such that it applies to any DeclRefExpr.
Doing it in the post-walk meant we ended up walking the children twice, which lead to duplicate diagnostics and incorrect inference of the level of application for function references. Move it to the pre-walk, ensuring that we resolve any operator references before folding.
hamishknight
force-pushed
the
foldable-tangent
branch
from
3feeeac to
7971056
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Jul 31, 2024
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing it in the post-walk meant we ended up walking the children twice, which led to duplicate diagnostics and incorrect inference of the level of application for function references. Move it to the pre-walk, ensuring that we resolve any operator references before folding.
Resolves #75527