Skip to content

Enhance README.md for adding 'sh' to the code block. #75545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lamtrinhdev
Copy link
Contributor

Enhance README.md for adding 'sh' to the code block.

@lamtrinhdev
Copy link
Contributor Author

Dear @parispittman ,

I have a minor update link for README.md. Could you please help me to review it?

Thanks,
Lam

Copy link
Contributor

@LucianoPAlmeida LucianoPAlmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good small improvement :)

@LucianoPAlmeida
Copy link
Contributor

@swift-ci Please smoke test

@LucianoPAlmeida
Copy link
Contributor

My approval is gray which means that I probably lost write access, I've been away from swift repo for a while so may this is due inactivity or more likely due to change of repo?
cc @xedin, @AnthonyLatsis

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Aug 15, 2024

I think you should contact @shahmishal about loss of write access. Likely not intentional, but I wouldn’t know.

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Aug 15, 2024

@lamtrinhdev Thank you. Please squash your commits and provide a meaningful commit message before we proceed.

@lamtrinhdev
Copy link
Contributor Author

Dear @AnthonyLatsis and @LucianoPAlmeida ,

Thank you for your support. Let me close this PR and create the new PR at #75981 .

Thanks,
Lam

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Aug 20, 2024

You do not need to create a new PR to edit your commit history. Next time, please prefer an interactive rebase instead (see https://github.com/swiftlang/swift/blob/main/docs/HowToGuides/FAQ.md#how-do-i-clean-up-my-git-history). Rewriting commit history is a very common practice, often done tens of times throughout the lifetime of a PR to reorganize, fix up, or finalize changes.

Need help? Reach out any time!

@lamtrinhdev
Copy link
Contributor Author

Dear @AnthonyLatsis ,

Thank you for your support. I learned the new things.

Thanks,
Lam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants