-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Enhance README.md for adding 'sh' to the code block. #75545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enhance code block in README.md .
Dear @parispittman , I have a minor update link for README.md. Could you please help me to review it? Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good small improvement :)
@swift-ci Please smoke test |
My approval is gray which means that I probably lost write access, I've been away from swift repo for a while so may this is due inactivity or more likely due to change of repo? |
I think you should contact @shahmishal about loss of write access. Likely not intentional, but I wouldn’t know. |
@lamtrinhdev Thank you. Please squash your commits and provide a meaningful commit message before we proceed. |
Dear @AnthonyLatsis and @LucianoPAlmeida , Thank you for your support. Let me close this PR and create the new PR at #75981 . Thanks, |
You do not need to create a new PR to edit your commit history. Next time, please prefer an interactive rebase instead (see https://github.com/swiftlang/swift/blob/main/docs/HowToGuides/FAQ.md#how-do-i-clean-up-my-git-history). Rewriting commit history is a very common practice, often done tens of times throughout the lifetime of a PR to reorganize, fix up, or finalize changes. Need help? Reach out any time! |
Dear @AnthonyLatsis , Thank you for your support. I learned the new things. Thanks, |
Enhance README.md for adding 'sh' to the code block.